Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(data-warehouse): simple batching for now #19107

Closed
wants to merge 2 commits into from
Closed

chore(data-warehouse): simple batching for now #19107

wants to merge 2 commits into from

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Dec 5, 2023

Problem

  • data imports aren't batched so every api call results in the pipeline being run

Changes

  • send 1000 records at a time

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

@posthog-bot
Copy link
Contributor

Hey @EDsCODE! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@EDsCODE
Copy link
Member Author

EDsCODE commented Dec 20, 2023

No need after #19338

@EDsCODE EDsCODE closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EDsCODE @posthog-bot